Minor fixes#51
Merged
rmordechay merged 3 commits intormordechay:mainfrom Mar 28, 2025
Merged
Conversation
Closed
rmordechay
reviewed
Mar 23, 2025
|
|
||
| <MACRO_IDENTIFIER_STATE> { | ||
| {WHITE_SPACE} { return WHITE_SPACE; } | ||
| {BACKSLASH} { return WHITE_SPACE; } |
Owner
There was a problem hiding this comment.
Can you please explain more about this one? And also can you add steps to reproduce? I'm saying that because I cannot even remember how many nights I spent to make macros work in this plugin and this touches the core of the logic so I'm very very afraid to touch anything that is related to macros
Contributor
Author
There was a problem hiding this comment.
#define \
EXAMPLE 10
without this fix:
with this fix:
rmordechay
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #47 (part 1 of 4)