Skip to content

GLSL builtins fixes#52

Merged
rmordechay merged 5 commits intormordechay:mainfrom
FalsePattern:pr2
Mar 28, 2025
Merged

GLSL builtins fixes#52
rmordechay merged 5 commits intormordechay:mainfrom
FalsePattern:pr2

Conversation

@FalsePattern
Copy link
Copy Markdown
Contributor

  • Fixed Dynamic type check is problematic! #42 - matrix * vector -> vector
  • Fixed broken swizzling for the stpq group (also included the generator code as reference)
  • Added compatibility profile uniforms from the khronos spec
  • Fixed nested builtin struct namespace pollution

Supersedes #47 (part 2 of 4)

@FalsePattern FalsePattern mentioned this pull request Mar 6, 2025
uvec2 usubBorrow(highp uvec2 x, highp uvec2 y, out lowp uvec2 borrow);
uvec3 usubBorrow(highp uvec3 x, highp uvec3 y, out lowp uvec3 borrow);
uvec4 usubBorrow(highp uvec4 x, highp uvec4 y, out lowp uvec4 borrow);
vec4 ftransform(); No newline at end of file
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that the functions are alphabetically sorted

@rmordechay
Copy link
Copy Markdown
Owner

@FalsePattern Thanks again for your contribution. Great work. Sorry again that it takes so much time. I can't find time for this plugin recently.
Let's finish the 3 small ones, make a release, and then for the bigger one I will need more time to review.

@rmordechay rmordechay merged commit 95543e8 into rmordechay:main Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dynamic type check is problematic!

2 participants