Rewrite createAblyHandler to address channel race conditions #5349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updates
createAblyHandlerto address some race conditions that @jscheid ran into. (He wrote this and shared it with me, I updated the tests.)It uses Ably 2+ which requires some changes, and has some changes of its own as shown in the diff of the tests:
onErrorhandler, so those handlers should be moved to.catch(...). Those shouldn't require updates in an app's subscription code those, since they're internal tocreateAblyHandler.onErroris called with a "payload" object whose.errorsproperty contains the errors -- but again, I don't think this would go in application code.