Skip to content

Fix bug in VTK binary reader #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmrsk merged 1 commit into from
Mar 2, 2026
Merged

Fix bug in VTK binary reader #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
116 changes: 116 additions & 0 deletions Source/EBGeometry_ParserImplem.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,82 @@ Parser::readVTK(const std::string& a_filename) noexcept

vtk.setPointDataScalars(arrayName, scalarData);
}
else if (dataKeyword == "VECTORS" || dataKeyword == "NORMALS") {
std::string arrayName, dataType;
ss >> arrayName >> dataType;

const size_t bytesPerElem = (dataType == "double") ? 8 : 4;
filestream.seekg(numData * 3 * bytesPerElem, std::ios_base::cur);
filestream.get(); // consume trailing '\n'
}
else if (dataKeyword == "FIELD") {
std::string fieldName;
size_t numArrays;
ss >> fieldName >> numArrays;

for (size_t a = 0; a < numArrays; a++) {
std::getline(filestream, line);
std::stringstream as(line);
std::string arrayName, dataType;
size_t numComponents, numTuples;
as >> arrayName >> numComponents >> numTuples >> dataType;

if (dataType == "float") {
if (numComponents == 1) {
std::vector<T> scalarData;
scalarData.reserve(numTuples);
for (size_t i = 0; i < numTuples; i++) {
scalarData.emplace_back(static_cast<T>(readBinaryFloat()));
}
vtk.setPointDataScalars(arrayName, scalarData);
}
else {
filestream.seekg(numComponents * numTuples * 4, std::ios_base::cur);
}
}
else if (dataType == "double") {
if (numComponents == 1) {
std::vector<T> scalarData;
scalarData.reserve(numTuples);
for (size_t i = 0; i < numTuples; i++) {
scalarData.emplace_back(static_cast<T>(readBinaryDouble()));
}
vtk.setPointDataScalars(arrayName, scalarData);
}
else {
filestream.seekg(numComponents * numTuples * 8, std::ios_base::cur);
}
}
else if (dataType == "int") {
if (numComponents == 1) {
std::vector<T> scalarData;
scalarData.reserve(numTuples);
for (size_t i = 0; i < numTuples; i++) {
scalarData.emplace_back(static_cast<T>(readBinaryInt()));
}
vtk.setPointDataScalars(arrayName, scalarData);
}
else {
filestream.seekg(numComponents * numTuples * 4, std::ios_base::cur);
}
}
else if (dataType == "char" || dataType == "unsigned_char") {
filestream.seekg(numComponents * numTuples * 1, std::ios_base::cur);
}
else if (dataType == "short" || dataType == "unsigned_short") {
filestream.seekg(numComponents * numTuples * 2, std::ios_base::cur);
}
else if (dataType == "long" || dataType == "unsigned_long") {
filestream.seekg(numComponents * numTuples * 8, std::ios_base::cur);
}
else {
std::cerr << "Parser::readVTK - Unsupported FIELD data type: " << dataType << "\n";
break;
}

filestream.get(); // consume trailing '\n' after binary data
}
}
else if (dataKeyword == "CELL_DATA") {
// Back up - we've hit the next section
filestream.seekg(-static_cast<int>(line.length()) - 1, std::ios_base::cur);
Expand Down Expand Up @@ -1481,6 +1557,46 @@ Parser::readVTK(const std::string& a_filename) noexcept

vtk.setCellDataScalars(arrayName, scalarData);
}
else if (dataKeyword == "FIELD") {
std::string fieldName;
size_t numArrays;
ss >> fieldName >> numArrays;

for (size_t a = 0; a < numArrays; a++) {
std::getline(filestream, line);
std::stringstream as(line);
std::string arrayName, dataType;
size_t numComponents, numTuples;
as >> arrayName >> numComponents >> numTuples >> dataType;

size_t bytesPerElem = 0;
if (dataType == "float" || dataType == "int")
bytesPerElem = 4;
else if (dataType == "double")
bytesPerElem = 8;
else if (dataType == "char" || dataType == "unsigned_char")
bytesPerElem = 1;
else if (dataType == "short" || dataType == "unsigned_short")
bytesPerElem = 2;
else if (dataType == "long" || dataType == "unsigned_long")
bytesPerElem = 8;

if (bytesPerElem > 0) {
filestream.seekg(numComponents * numTuples * bytesPerElem, std::ios_base::cur);
}
else {
std::cerr << "Parser::readVTK - Unsupported CELL_DATA FIELD type: " << dataType << "\n";
break;
}

filestream.get(); // consume trailing '\n'
}
}
else if (dataKeyword == "POINT_DATA") {
// Back up - we've hit the next section
filestream.seekg(-static_cast<int>(line.length()) - 1, std::ios_base::cur);
break;
}
}
}
}
Expand Down