Dev #41
Merged
Dev #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re mode selection - Update version from 0.10.4 to 0.10.5 in package.json - Add CHANGELOG.md entry documenting menu navigation improvements and restore mode selection - Add "Back" and "Back to main menu" options to all interactive menus (container creation wizard, backup/restore flows) - Implement step-by-step container creation flow with back navigation at each step (engine → version → name → database → port) - Add restore mode selection
…ed error handling - Update version from 0.10.5 to 0.10.6 in package.json - Add CHANGELOG.md entry documenting restore flow refactoring and cross-platform improvements - Refactor handleRestore from recursive to loop-driven using while(true) with continue for back navigation to eliminate stack growth - Change dumpFromConnectionString to return warnings in result object instead of logging directly; CLI callers now handle display for
…support - Update unit test count from 302 to 378 in CLAUDE.md architecture section - Remove integration test count (28 tests) as it's no longer accurate - Add 'sqlite' to ContainerConfig engine type union in CLAUDE.md - Remove sqlite-registry.json from README architecture diagram (no longer used) - Mark "Overwrite existing databases on restore" task as complete in TODO.md
… prompts - Change empty connection string and backup path handling from return to continue to loop back to container selection - Update all "Go back to start" comments to "Return to container selection" for clarity - Add comment explaining that client tool installation counts toward maxAttempts - Replace inline press-enter prompts with pressEnterToContinue() helper function for consistency
…gration tests - Replace inline inquirer press-enter prompts with pressEnterToContinue() helper in backup-handlers.ts (4 occurrences) - Export getInstallCommand from version-validator.ts for testing - Add comprehensive CLI backup and restore workflow integration tests covering: - PostgreSQL container creation and test data setup - SQL backup creation with --format and --json options - Backup restoration to new database testing
- Update unit test count from 378 to 381 in CLAUDE.md - Update CONTRIBUTING.md test coverage section with current counts (381 unit, 38 integration, 38 CLI E2E) - Add CHANGELOG.md unreleased section documenting: - Fixed interactive restore navigation with pressEnterToContinue() helper - Added getInstallCommand() unit tests and CLI E2E tests for backup/restore/clone - Exported getInstallCommand() for testability
refactor: improve Unicode width handling and consolidate test scripts - Replace custom padWithEmoji() with string-width library for accurate Unicode width calculations in engine-handlers.ts - Add string-width dependency for proper multi-byte character width handling - Refactor test scripts to use npm-run-all for cross-package-manager compatibility - Add npm-run-all as dev dependency - Update TODO.md to mark package-manager mismatch task as complete - Add new TODO items for build step optimization
- Add push trigger for dev branch to CI workflow - Add TODO comment to remove after testing is complete
…check automation - Update version from 0.10.6 to 0.11.0 in package.json - Add PostgreSQL 18.1.0 support and set as new default version - Add pre-commit hook to check for new PostgreSQL versions on zonky.io (scripts/check-pg-versions.ts) - Update SUPPORTED_MAJOR_VERSIONS to include '18' in binary-urls.ts - Add '18': '18.1.0' to FALLBACK_VERSION_MAP - Update defaultVersion and latestVersion to '18' in engine-defaults.ts - Update documentation
…anager tests - Add '18': '18.1.0' test case to binary-manager.test.ts version resolution tests - Add '18' to major version test array in version-validator.test.ts getInstallCommand tests - Update POSTGRESQL_VERSION_MAP with '18': '18.1.0' mapping
…e and update CLAUDE.md architecture - Expand FEATURE.md from 231 to 1145 lines with detailed implementation guide including: - Table of contents with 13 major sections - Quick start checklist for tracking implementation progress - Complete BaseEngine method documentation with TypeScript signatures and implementation guidance - Engine types explanation (server-based vs file-based databases) - Binary management strategies
- Change node-version from '22' to '20' in all 6 CI workflow jobs (unit tests, integration tests, CLI E2E tests, and platform-specific builds)
- Change node-version from '20' to '22' in all 6 CI workflow jobs (unit tests, integration tests, CLI E2E tests, and platform-specific builds)
…rallel execution - Add --test-concurrency=1 to test:pg, test:mysql, test:sqlite, test:unit, and test:cli scripts - Ensures tests run sequentially to avoid resource conflicts and race conditions
…est concurrency documentation - Update PostgreSQL download commands from version 17 to 18 in both integration test and CLI E2E test jobs - Add comments noting version 18 is the default - Add test concurrency documentation to CLAUDE.md and CONTRIBUTING.md explaining --test-concurrency=1 flag usage - Document Node 22 macOS worker thread serialization bug that necessitates sequential test execution
… updates - Add NOTE comments in CI workflow linking PostgreSQL version to engine-defaults.ts defaultVersion - Reference CLAUDE.md "Updating Supported Engine Versions" section for version change process - Add step 4 to CLAUDE.md version update checklist documenting CI workflow update requirement - Clarify that CI workflow updates are only needed when changing the default version
…testing - Comment out push trigger for dev branch in CI workflow - Update TODO comment to indicate trigger is available for future testing - Keep workflow_dispatch and pull_request triggers active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.