Dev #52
Merged
Dev #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add REDIS-SPEC.md with complete specification for implementing Redis support in SpinDB. The specification includes: - Overview of Redis vs other engines (numbered databases, Redis commands) - Complete list of 5 files to create (engine, backup, restore, etc.) - Complete list of 12 files to modify (types, config, tests, CI) - Edge cases and special handling (Windows, backup format, etc.) - 14+ integration tests required - CI/CD workflow requirements for macOS/Linux - Pass/fail criteria for implementation verification This spec is designed to be used by an LLM code agent to implement Redis support without causing regressions to existing engines.
…tion strategy - Add new section explaining why PostgreSQL uses precompiled binaries while MySQL/MongoDB use system installs - Document zonky.io embedded PostgreSQL binaries project advantages (cross-platform, Maven Central hosting, ~45MB size) - Explain lack of equivalent embedded distributions for MySQL/MongoDB - Update MySQL description to include MongoDB in system installation detection - Clarify multi-version support limitations for MySQL/MongoDB
- Update CHANGELOG.md with version 0.12.4 release notes - Add comprehensive Redis specification enhancements to REDIS-SPEC.md: - Add UI and menu integration section with engine icons and terminology - Add getKeyCount/getDbSize helper functions for integration tests - Add TransactionManager usage examples for rollback support - Add waitForReady retry loop implementation - Add Redis configuration file generation approach - Enhance edge
Claude/add redis support b wd30
…ntegration - Add Redis engine implementation with support for versions 6, 7, and 8 - Add system binary detection for redis-server and redis-cli - Add backup/restore via BGSAVE and RDB files - Add clone support via backup/restore workflow - Add `spindb run` support for Redis commands via files or inline - Add `--iredis` flag for enhanced CLI support - Add multi-version support via Homebrew versioned formulas - Add macOS and Linux CI
- Add windows-latest to Redis CI test matrix - Add Redis installation via Chocolatey (redis-64 package) - Add PATH configuration for Redis binaries on Windows - Add Redis verification step for Windows - Update CI comments to reflect Windows support via Chocolatey - Mark Windows Redis CI task as complete in TODO.md
…ction and verification - Merge Redis installation and PATH configuration into single step - Add recursive search across multiple possible installation directories - Add detailed logging for installation path detection - Add fallback search in chocolatey lib directory when standard paths fail - Enhance verification step with fallback executable search - Add explicit error handling and exit codes for missing binaries - Add directory
…s installation - Replace Chocolatey installation with direct download from tporadowski/redis GitHub releases - Add GitHub Actions cache for Redis binaries on Windows (C:\Redis) - Simplify Windows Redis installation to single download/extract step - Remove complex PATH detection logic and recursive search fallbacks - Update manual installation instructions to recommend winget over Chocolatey - Remove Chocolatey, Scoop package definitions
…on and error handling - Add helper function to search and add MongoDB tools to PATH across multiple installation directories - Add retry logic for mongodump verification with automatic reinstall on failure - Add nested directory handling for Redis zip extraction on Windows - Refactor manual installation instructions into reusable displayManualInstallInstructions function - Change redis-cli stderr from error to warning (non-fatal warnings
- Remove push trigger for feature/redis branch after Redis implementation completion - Restore standard CI workflow to only run on pull requests to main and manual dispatch
- Update version from 0.13.1 to 0.13.2 in package.json - Add CHANGELOG entry for Windows Redis CI support - Document direct GitHub download approach replacing Chocolatey - Document comprehensive path detection and enhanced error handling
Feature/redis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.