Dev #53
Merged
Dev #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Redis to list of system binary engines (alongside MySQL, MongoDB) - Document Redis's lack of official portable distribution - Note macOS/Linux reliance on system packages vs Windows community port - Update multi-version support limitations to include Redis - Add Redis binary sourcing details to CLAUDE.md technical reference
- Add "Create new" option to container list menu with green + indicator - Add handler to launch create flow from list menu - Add navigation back to list menu after creation - Position create option above back button with separator
…ation and startup - Add conflict detection for ports used by other SpinDB containers - Add conflict detection for ports used by external processes - Add automatic port suggestion when default port is unavailable - Add interactive conflict resolution with retry option during port selection - Add container-specific error messages when port conflicts prevent startup - Enhance port prompt to show warnings and allow choosing different
…backup/restore UX - Add `backups` command to list backup files in current or specified directory - Detects backup format from file extension (.sql, .dump, .sqlite, .archive, .rdb, .redis, .sql.gz) - Shows filename, size, modified time, format, and engine icon - Add --all flag to include backups from ~/.spindb/backups - Add --limit flag to control number of results (default: 20) - Add --json flag for machine-readable output
…B cross-database restore - Add comprehensive backup format tests for MySQL, PostgreSQL, MongoDB, and Redis - Test SQL format (.sql) backup creation and content verification - Test compressed format (.sql.gz, .dump, .archive) backup creation - Test format-specific restore operations with data verification - Test Redis text format (.redis) backup/restore with merge vs replace modes - Test content-based format detection for Redis
…rs and detection - Add MongoDB and Redis engine types and detection functions to cli/helpers.ts - Add MongoDB and Redis to engine-handlers.ts menu display with icons and version info - Add handleMongodbInfo() and handleRedisInfo() functions showing installation details, containers, and uninstall instructions - Add menu choices for MongoDB and Redis info screens with action handlers - Update FEATURE.md checklist to include cli/helpers.ts an
…tem-installed engines - Add version validation during container creation for MySQL, MongoDB, and Redis - Fail with helpful error if requested version is not installed - List available versions with install commands (e.g., `brew install redis@7`) - Store binary path in container config for version consistency across restarts - Containers use stored binary path when starting, preventing silent fallback - Legacy containers without
…ssages - Update Redis version validation to suggest correct formulas (redis@7.2, redis@8.2) - Update MySQL version validation to suggest mysql@8.0 instead of mysql@8.0.0 - Update MongoDB version validation to suggest mongodb-community@7.0 instead of mongodb-community@7.0.0 - Add CHANGELOG entry documenting corrected formula suggestions
… messages - Update MySQL version validation to suggest mysql@8 instead of mysql@8.0 - Update MongoDB version validation to suggest mongodb-community@7 instead of mongodb-community@7.0 - Add Redis formula version mapping (6→6.2, 7→7.2, 8→8.2) with getHomebrewFormula() helper - Update Redis version validation to suggest correct minor-versioned formulas (redis@7.2, redis@8.2) - Apply corrected formula suggestions to both container
…gestions - Remove unused imports: basename, stat, dirname, statSync, resolve, existsSync, and constants from various files - Update MongoDB version validation to suggest mongodb-community@X.0 instead of mongodb-community@X - Refactor Redis getHomebrewFormula() to return object with formula name and isExact flag - Update Redis version validation to provide contextual install hints: - Show exact formula (redis@8.2) when versioned formula exists
… engine - Remove file header documentation comment from engines/redis/index.ts - Reformat long logDebug() and throw statements to multi-line for better readability
…ule and add Windows path quoting - Move getVersionInstallHint() from index.ts to binary-detection.ts for better organization - Remove duplicate getHomebrewFormula() function from index.ts (logic now in getVersionInstallHint) - Update version validation error messages to use getVersionInstallHint() for platform-specific install instructions - Add Windows path quoting for mysqldump binary in MySQL backup operations
…to Redis binary detection - Add getRedisServerExe() and getRedisCliExe() helpers to append platform-specific executable extensions - Replace string concatenation with path.join() for cross-platform path construction - Update all binary path construction to use join() with executable name helpers - Replace regex-based dirname extraction with path.dirname() for cross-platform compatibility - Add comments clarifying Unix-only Homebrew paths vs
… obvious comments - Replace JSDoc-style `/** */` comments with `//` for single-line comments throughout codebase - Remove obvious comments that restate what code does (e.g., "Check if already running", "Ensure directory exists") - Remove file header comments from cli/commands/create.ts and cli/index.ts - Update STYLEGUIDE.md to document comment conventions: - No file headers unless purpose is ambiguous - No JSDoc for one-li
- Add isWindows() import from platform-service to backup.ts - Update buildRedisCliCommand() to use different quoting strategies for Windows vs Unix - Windows: use double quotes with backslash-escaped internal quotes for cmd.exe - Unix: use single quotes with quote-in-quote escaping for shell special characters - Update function comment to clarify platform-specific quoting behavior - Add whitespace to Windows special character regex
…ersion support - Add BINARY-PLANS.md documenting potential approaches for downloadable binaries - Analyze Redis as best candidate (trivial compilation, 7-9 MB binaries, existing proof of concept) - Document MariaDB4j limitations (outdated to 10.2.11, no ARM64, Java-only) - Propose forking MariaDB4j to add ARM64 support and update to current versions - Note MongoDB's large binary size (~300-500 MB) makes distribution less practical
…section - Document active PR #1321 adding ARM64 support to MariaDB4j in BINARY-PLANS.md - Add table showing macOS ARM64 versions (10.5.29, 10.6.24, 10.11.15, 11.8.5) and Linux ARM64 versions (10.11.15, 11.4.9) - Note implementation uses Homebrew for macOS and official Docker images for Linux - Include PR status and local development path - Add new "Related Work" section to README.md linking to MariaDB4j PR #1321 - Cross-reference
… project - Delete BINARY-PLANS.md document exploring future binary distribution approaches - Update CLAUDE.md to simplify binary sourcing explanation and reference hostdb for future plans - Update README.md "Related Work" section to reference hostdb project instead of MariaDB4j PR #1321 - Add "Critical: Version Containerization Uses Wrong Binary" issue to TODO.md documenting bug where containers may use incorrect system binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.