step4 finished waiting comments

[ziweiq-29]

qoi.cc output:

ziweiq2@ragnaros build]$ pressio -i /home/ziweiq2/LibPressio/dataset/SDRBENCH-EXASKY-NYX-512x512x512/baryon_density.f32 -b compressor=sz3 -o abs=1e-4 -d 512 -d 512 -d 512 -t float -b qoi:metric=external -o external:command="python /home/ziweiq2/halo/run_pressio_pipeline.py   --external_mode" -b external:launch_metric=print -o external:use_many=1 -m qoi -M all
Registering qoi plugin
launch_begin 
command python /home/ziweiq2/halo/run_pressio_pipeline.py --external_mode 
stdout "external:api=json:1
{\"mean\": 158.72672185190837, \"median\": 150.31300675590253}
"
stderr ""
error 0
return 0
launch_begin --api 6 --config_name external --eval_uuid ada0c655-ea68-f82c-3f45-f06d47dc5adc --input /home/ziweiq2/LibPressio/benchmark/libpressio/build/.pressioin9BmXUu --decompressed /home/ziweiq2/LibPressio/benchmark/libpressio/build/.pressiooutLzXFh7 --type float --dim 512 --dim 512 --dim 512 
command python /home/ziweiq2/halo/run_pressio_pipeline.py --external_mode --api 6 --config_name external --eval_uuid ada0c655-ea68-f82c-3f45-f06d47dc5adc --input /home/ziweiq2/LibPressio/benchmark/libpressio/build/.pressioin9BmXUu --decompressed /home/ziweiq2/LibPressio/benchmark/libpressio/build/.pressiooutLzXFh7 --type float --dim 512 --dim 512 --dim 512 
stdout "external:api=json:1
{\"mean\": 158.72672185190837, \"median\": 150.31300675590253}
"
stderr ""
error 0
return 0
[QOI] Total values in vector: 2
[QOI] values[0] = 158.727
[QOI] values[1] = 150.313
composite:compression_rate<double> = <empty>
composite:compression_rate_many<double> = <empty>
composite:decompression_rate<double> = <empty>
composite:decompression_rate_many<double> = <empty>
external:error_code<int32> = 0
external:input_times<data> = data{ type=double dims={1, } domain=malloc has_data=[228.741, ]}
external:output_times<data> = data{ type=double dims={1, } domain=malloc has_data=[223.192, ]}
external:results:mean<double> = 158.727
external:results:median<double> = 150.313
external:return_code<int32> = 0
external:runtime<double> = 31.2796
external:stderr<char*> = ""
qoi:data<data> = data{ type=double dims={2, } domain=malloc has_data=[158.727, 150.313, ]}

external_metric output:
[ziweiq2@ragnaros halo]$ python run_pressio_pipeline.py --external_mode
external:api=json:1
{"mean": 158.72672185190837, "median": 150.31300675590253}
[ziweiq2@ragnaros halo]$

[robertu94]

In general, this is looking good. I'm glad you've gotten it working. While the code you have works, I've suggested some simpler versions below.

Also you can close #46 and #47. Going forward, please just continue to add new commits to this PR, and I'll provide feedback here.

[robertu94]

please remove comments in cmake that are just commented out code.