#10 Add getUrl() method #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getUrl method generates a data URL for a file stored on the SMB share. It reads the file, detects its MIME type, and returns a string that embeds the file content as a base64-encoded data URL.
Why create it:
This method allows users to easily retrieve SMB-stored files as data URLs, which can be directly embedded in web pages or APIs without needing a public HTTP endpoint or temporary file. It simplifies file sharing and previewing, especially for web applications.
Provides a standard way to get file contents as a data URL, matching features in other Flysystem adapters.
Enables seamless integration with web frontends and APIs that expect data URLs.
Reduces the need for additional file hosting or proxying solutions when working with SMB shares.
Issue: #10