Silence warnings about empty if/else bodies in release builds.#1
Open
hporten wants to merge 1 commit intorobinhouston:masterfrom
Open
Silence warnings about empty if/else bodies in release builds.#1hporten wants to merge 1 commit intorobinhouston:masterfrom
hporten wants to merge 1 commit intorobinhouston:masterfrom
Conversation
As debug_print expands to nothing unless PADWALKER_DEBUGGING is set gcc will warn about "suggest braces around empty body in an ‘if’ statement" (same for ´else´) if ´-Wempty-body´ is used. And that one is implied by ´-W´. By defining the macro to a no-op statement we provide a suitable replacement rather than nothing. A common technique also used for e.g. assert().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As debug_print expands to nothing unless PADWALKER_DEBUGGING is
set gcc will warn about "suggest braces around empty body in an
‘if’ statement" (same for ´else´) if ´-Wempty-body´ is used.
And that one is implied by ´-W´.
By defining the macro to a no-op statement we provide a
suitable replacement rather than nothing. A common technique
also used for e.g. assert().