Skip to content

fix: add cursor agent support#409

Open
bgoosmanviz wants to merge 1 commit intoroborev-dev:mainfrom
bgoosmanviz:fix/support-for-cursor-agent
Open

fix: add cursor agent support#409
bgoosmanviz wants to merge 1 commit intoroborev-dev:mainfrom
bgoosmanviz:fix/support-for-cursor-agent

Conversation

@bgoosmanviz
Copy link

No description provided.

@roborev-ci
Copy link

roborev-ci bot commented Mar 2, 2026

roborev: Combined Review (ffc4cc5)

Verdict: The PR adds support for mapping the "agent" CLI command to the "cursor" agent
, but requires a high-priority fix for a compilation error in the tests.

High Severity

  • internal/agent/agent_test.go (Lines 45-46)
    • Problem: TestCanonicalNameAliases attempts to call CanonicalName(), but the actual
      function handling alias resolution in internal/agent/agent.go is unexported and named resolveAlias(). This will result in a compilation error.
    • Fix: Change CanonicalName(tt.input) to resolveAlias(tt.input) inside the test loop.

Synthesized from 3 reviews (agents: codex, gemini | types: default, security)

Copy link
Collaborator

@mariusvniekerk mariusvniekerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given how this issue arose we need more validation on the config /params for agents. Returning an error for an unknown explicitly asked for agent feels appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants