Restore separate P/F verdict column in TUI queue#427
Merged
Conversation
The combined Status column (showing Pass/Fail/Done/etc.) was confusing. Split it back into separate Status and P/F columns: Status shows the job state (Queued/Running/Done/Error/Canceled), P/F shows the verdict (P/F/-). The P/F column sits between Status and Closed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract statusColor and verdictColor helpers from the inline StyleFunc to make them unit-testable. Add TestStatusColor, TestVerdictColor, and TestParseColumnOrderAppendsMissing tests. Change doneStyle from green (same as passStyle) to blue so Done and Pass are visually distinct. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Unknown job statuses previously got queuedStyle (yellow), which could mislead users into thinking the job is queued. Return nil so no foreground color is applied, matching the behavior before the refactor. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of hardcoding 8 chars (to fit "Canceled"), size the Status column to the widest status string actually present. Saves 2 chars when no canceled jobs are visible (e.g. "Done" = 4, "Queued" = 6). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Verifies the Status column auto-sizes to the widest label present: 6 for Done/Queued (header floor), 7 for Running, 8 for Canceled. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
statusColor/verdictColorinto testable helpers; return nil for unknown statuses instead of defaulting to queued colormigrateColumnConfigentries to reset old default orders (both pre-rename and combined-status layouts)TestStatusColor,TestVerdictColor,TestParseColumnOrderAppendsMissing,TestStatusColumnAutoWidthtestsTest plan
go test ./...)go vetandgo fmtclean🤖 Generated with Claude Code