Post-DTC fixes #18
Merged
Post-DTC fixes #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3d
requested review from
MartinLocker,
frantisekbrabec and
tajgr
and removed request for
MartinLocker,
frantisekbrabec and
tajgr
Member
Author
|
OK, the tests are running now - I added all necessary DTC packages into requirements.txt, but just "ultralytics" took over 2 minutes to install, so I decided to patch it together with private external doctor function. |
tajgr
reviewed
Nov 9, 2025
| @@ -31,15 +31,15 @@ | |||
|
|
|||
| def geo_length(pos1, pos2): | |||
Collaborator
Member
Author
There was a problem hiding this comment.
thanks for your comment - it is actually originally copy & paste from:
https://github.com/robotika/osgar/blob/master/osgar/ro2018.py#L20
and then another copy & paste from
https://github.com/robotika/osgar-apps/blob/master/roboorienteering/ro.py#L16
... note, that both are untouched, i.e. most probably still wrong.
Member
Author
|
merging, not to block further development - feel free to comment for future revision, thanks m. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some fixes and visualization tools after DTC was finished.