Support environment variables in config #1032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tajgr
reviewed
Sep 11, 2025
Collaborator
tajgr
left a comment
tajgr
left a comment
There was a problem hiding this comment.
For the first view it looks good, but it is critical part and i would like to test it. I won't be able to do that until tomorrow.
Member
Author
sure, no problem - I can continue from this branch and test it a bit more. Thanks m. |
tajgr
approved these changes
Sep 12, 2025
Collaborator
tajgr
left a comment
tajgr
left a comment
There was a problem hiding this comment.
It's working. Just, it may be also added to the zmqrouter.. But it is not necessary to do it now.
Member
Author
|
OK, thanks - good point. I would add it once there is a user for it (which could verify the functionality). thank you - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is 5 robots which should behave differently in particular situations. There is already
OSGAR_LOGS_PREFIXto distinguish origin of the logfile, so this is step further, that the robots can use this info and behave differently base on this info. OTOH we still want to keep the replay capability and this saving this environment info into config.Example of new config (automatically filled):