lidarview.py - use black color for undefined depth pixels #1034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Any comment? Black is not nice "color", but it is at least obvious how bad the depth data are ... (bad, I mean limited) |
tajgr
approved these changes
Oct 10, 2025
Collaborator
tajgr
left a comment
tajgr
left a comment
There was a problem hiding this comment.
I like the black color. It works fine. Only, if I move the mouse over the screen the image stops and resumes with a delay. But, it seems that it is not related to this PR.
Member
Author
|
OK, thanks - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original color maps are quite misleading - they look nice, but the fact that half of the pixels have value 0 which means the depth is unknown/undefined is not well visible. So this change replaces nice OpenCV colors with extra black mask.
Note, that I had to change it on two places, and I am not sure why (actually the first one could be maybe removed?).
