Skip to content

Conversation

@m3d
Copy link
Member

@m3d m3d commented Oct 9, 2025

This is a simple wrapper of ffmpeg, where I always forgot the detailed parameters. The functionality is limited to H.264 and H.265 streams (?), and default audio configuration.

@m3d m3d requested review from jisa and tajgr October 9, 2025 12:48
@tajgr
Copy link
Collaborator

tajgr commented Oct 12, 2025

It creates a video file with audio, but the FPS parameter is not working. So if I set the camera for low (or just different) fps, the audio and video is not synchronized.

@m3d
Copy link
Member Author

m3d commented Oct 12, 2025

It creates a video file with audio, but the FPS parameter is not working. So if I set the camera for low (or just different) fps, the audio and video is not synchronized.

Yes, correct - FPS is ignored (as well as other options) if you use ffmpeg to combine audio and video at the moment. Do you have recording with audio?

@tajgr
Copy link
Collaborator

tajgr commented Oct 12, 2025

I have no suggestion. Just Elena suggested moviepy...
Maybe, it could be useful some warning that if audio stream is used, other parameters like FPS are ignored.

@m3d
Copy link
Member Author

m3d commented Oct 16, 2025

OK, I removed the fps=25 default so from now on OpenCV default is used (seems to be 30) and asserted not implemented/supported parameters for video+audio combination. Thanks m.

Copy link
Collaborator

@tajgr tajgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is usable only with "correct" fps during recording.
Let's move.

@m3d m3d merged commit 2c98484 into master Oct 16, 2025
4 checks passed
@m3d m3d deleted the feature/video-with-audio branch October 16, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants