bluetooth detector for subt #940
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m3d
reviewed
Sep 25, 2021
| "robot": { | ||
| "modules": { | ||
| "wifi": { | ||
| "driver": "subt.bluetooth_signal:Bluetooth_signal", |
Member
There was a problem hiding this comment.
the class name should be CamelCase, i.e. BluetoothSignal ... and I would maybe just use shorter version bluetooth:Bluetooth
m3d
reviewed
Sep 25, 2021
| "wifi": { | ||
| "driver": "subt.bluetooth_signal:Bluetooth_signal", | ||
| "in": [], | ||
| "out": ["signalStrength"] |
Member
There was a problem hiding this comment.
here on the other hand I would use only small letters with underscores ... and again maybe just shorter signal
m3d
reviewed
Sep 25, 2021
| def run(self): | ||
| while self.is_bus_alive(): | ||
| signalStrength = bluetooth_scan() | ||
| now = self.publish("bluetoothscan", signalStrength) |
Member
There was a problem hiding this comment.
the name in configuration should correspond to your registered (and published) name, i.e. bluetoothscan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.