refactor(services): migrate to rosapi_service()/rosapi_type(), add tool tests (step4)#322
Open
stex2005 wants to merge 4 commits intofeature/step3from
Open
refactor(services): migrate to rosapi_service()/rosapi_type(), add tool tests (step4)#322stex2005 wants to merge 4 commits intofeature/step3from
stex2005 wants to merge 4 commits intofeature/step3from
Conversation
r-johnv
approved these changes
Apr 7, 2026
Contributor
r-johnv
left a comment
r-johnv
left a comment
There was a problem hiding this comment.
Same comment as the previous two reviews. rosapi_service and rosapi_type need to have a default in the event that version is not detected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 4 of 7 — targets
feature/step3(#281)/rosapi/strings inservices.py(6 service paths + 6 type strings) withrosapi_service()/rosapi_type()get_services,get_service_type,get_service_details,call_service) directlyChanges
ros_mcp/tools/services.py— import helpers, replace 12 hardcoded strings (+13 -12)tests/integration/test_services.py— 12 teststests/integration/scripts/run-services-tests.sh— per-module test runnerTesting
12 tests pass on all 4 distros (melodic, noetic, humble, jazzy), zero skips.
PR stack
Replaces #316 which was merged to the wrong base branch.