'strong' attibutes replaced with 'copy' in block properties #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1. Can you please merge it asap? |
Author
|
I don't have write access to this repository. So I'm waiting for merge too. |
|
This is an easy enough change. I fully recommend to merge this. |
Member
|
This is not necessary, and I'm generally against as it fosters block memory management paranoia. See: http://stackoverflow.com/questions/27152580/cocoa-blocks-as-strong-pointers-vs-copy @Krivoblotsky @protikhonov @fulldecent Any particular reason why you want this merge? |
balthisar
added a commit
to balthisar/RMStore
that referenced
this pull request
Dec 24, 2019
…icts, etc., I'm adding these manually, so the actual commits are not part of the git history, unfortunately. However this list indicates the original PR number and the author. - Add robotmedia#138 by @protikhonov. - Add robotmedia#150 by @seantb. - Add robotmedia#175 by @metasmile
everappz
added a commit
to everappz/RMStore
that referenced
this pull request
Mar 24, 2024
'strong' attibutes replaced with 'copy' in block properties robotmedia#138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've replaced "strong" attribute with "copy" in block properties.
"Note: You should specify copy as the property attribute, because a block needs to be copied to keep track of its captured state outside of the original scope. This isn’t something you need to worry about when using Automatic Reference Counting, as it will happen automatically, but it’s best practice for the property attribute to show the resultant behavior. For more information, see Blocks Programming Topics."
https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html