-
Notifications
You must be signed in to change notification settings - Fork 0
UI enhancements: hover indicators, category labels, delete confirmations, and improved item management #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
3
commits into
main
Choose a base branch
from
copilot/ui-enhancements-checklist-interaction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -16,11 +16,13 @@ export function ChecklistPage() { | |||
| deleteItem, | ||||
| addItem, | ||||
| setCurrentChecklist, | ||||
| deleteChecklist, | ||||
| } = useChecklistStore(); | ||||
|
|
||||
| const [isAddingItem, setIsAddingItem] = useState(false); | ||||
| const [isCreatingChecklist, setIsCreatingChecklist] = useState(false); | ||||
| const [newChecklistName, setNewChecklistName] = useState(''); | ||||
| const [isDeletingChecklist, setIsDeletingChecklist] = useState(false); | ||||
|
|
||||
| useEffect(() => { | ||||
| loadChecklists(); | ||||
|
|
@@ -48,6 +50,22 @@ export function ChecklistPage() { | |||
| setIsAddingItem(false); | ||||
| }; | ||||
|
|
||||
| const handleDeleteChecklistClick = () => { | ||||
| setIsDeletingChecklist(true); | ||||
| }; | ||||
|
|
||||
| const handleConfirmDeleteChecklist = async () => { | ||||
| if (currentChecklistId) { | ||||
| await deleteChecklist(currentChecklistId); | ||||
| setCurrentChecklist(null); | ||||
| setIsDeletingChecklist(false); | ||||
| } | ||||
| }; | ||||
|
|
||||
| const handleCancelDeleteChecklist = () => { | ||||
| setIsDeletingChecklist(false); | ||||
| }; | ||||
|
|
||||
| if (isLoading && checklists.length === 0) { | ||||
| return ( | ||||
| <div className="flex items-center justify-center h-64"> | ||||
|
|
@@ -93,12 +111,21 @@ export function ChecklistPage() { | |||
| {currentChecklist?.name || 'Packing Checklist'} | ||||
| </h1> | ||||
| </div> | ||||
| <button | ||||
| onClick={() => setIsCreatingChecklist(true)} | ||||
| className="px-4 py-2 bg-accent text-white rounded-lg hover:opacity-90 focus:outline-none focus:ring-2 focus:ring-accent" | ||||
| > | ||||
| New Checklist | ||||
| </button> | ||||
| {currentChecklist ? ( | ||||
| <button | ||||
| onClick={handleDeleteChecklistClick} | ||||
| className="px-4 py-2 bg-red-600 text-white rounded-lg hover:bg-red-700 focus:outline-none focus:ring-2 focus:ring-red-600" | ||||
| > | ||||
| Delete Checklist | ||||
| </button> | ||||
| ) : ( | ||||
| <button | ||||
| onClick={() => setIsCreatingChecklist(true)} | ||||
| className="px-4 py-2 bg-accent text-white rounded-lg hover:opacity-90 focus:outline-none focus:ring-2 focus:ring-accent" | ||||
| > | ||||
| New Checklist | ||||
| </button> | ||||
| )} | ||||
| </div> | ||||
|
|
||||
| {currentChecklist && ( | ||||
|
|
@@ -118,6 +145,29 @@ export function ChecklistPage() { | |||
| )} | ||||
| </div> | ||||
|
|
||||
| {/* Delete Checklist Confirmation */} | ||||
| {isDeletingChecklist && currentChecklist && ( | ||||
| <div className="mb-6 p-4 bg-red-50 border border-red-500 rounded-lg"> | ||||
| <p className="text-sm text-gray-900 mb-3"> | ||||
| Are you sure you want to delete "{currentChecklist.name}"? This action cannot be undone. | ||||
| </p> | ||||
| <div className="flex gap-2"> | ||||
| <button | ||||
| onClick={handleConfirmDeleteChecklist} | ||||
| className="px-4 py-2 bg-red-600 text-white rounded-md hover:bg-red-700 focus:outline-none focus:ring-2 focus:ring-red-600" | ||||
| > | ||||
| Delete Checklist | ||||
| </button> | ||||
| <button | ||||
| onClick={handleCancelDeleteChecklist} | ||||
| className="px-4 py-2 bg-gray-100 text-gray-700 rounded-md hover:bg-gray-200 focus:outline-none focus:ring-2 focus:ring-gray-400" | ||||
| > | ||||
| Cancel | ||||
| </button> | ||||
| </div> | ||||
| </div> | ||||
| )} | ||||
|
|
||||
| {/* Create Checklist Form */} | ||||
| {isCreatingChecklist && ( | ||||
| <div className="mb-6 bg-white p-4 rounded-lg border border-gray-200 shadow-sm"> | ||||
|
|
@@ -218,7 +268,7 @@ export function ChecklistPage() { | |||
| {isAddingItem ? ( | ||||
| <AddItemForm | ||||
| checklistId={currentChecklist.id} | ||||
| category="Miscellaneous" | ||||
| category="" | ||||
|
||||
| category="" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
categoryparameter is still defined but no longer used in this component. The comment on line 6 acknowledges this is for "backward compatibility," but since this is an internal component (not a public API), there's no need to maintain backward compatibility. The parameter should be removed entirely from the interface and the function signature to keep the code clean and avoid confusion.