Added UTF-8 charset for setDocument, getDocument#18
Added UTF-8 charset for setDocument, getDocument#18ZuzooVn wants to merge 1 commit intorobtweed:masterfrom
Conversation
|
My main concern about this suggested change is whether it is compatible with people who don't need UTF-8. If it can be demonstrated that allows getDocument and setDocument to work across all scenarios, then I'll merge it. Agreed it will need specific tests for UTF-8 and non-UTF-8 use-cases |
|
@killmenot @robtweed WDYT? |
|
@ZuzooVn Yes, we have plan to merge this PR but first we need to complete other work. In the same time, could you please add unit and integration tests for that functionality? We'd like to make sure that UTF-8 and non-UTF-8 works in the same time |
|
Will be great if this PR is merged. We are using QEWD-Ripple with Redis and the cache keeps getting corrupted when address contains special characters (eg. Saint-François-de-l'Île-d'Orléans, QC, Canada). |
According to #17, I have made some modification for setDocument() and getDocument() function.
Please take a look at this pull request and tell me what you think.
Thanks
Nam Vu from ThinkLabs-VN