Update qewd-client.js - only override supplied values#2
Open
geoidesic wants to merge 1 commit intorobtweed:masterfrom
Open
Update qewd-client.js - only override supplied values#2geoidesic wants to merge 1 commit intorobtweed:masterfrom
geoidesic wants to merge 1 commit intorobtweed:masterfrom
Conversation
…'t supplied Currently if you supply an object, you're forced to override all of the defaults, which is overkill. Rather leave defaults intact if an override for that particular value wasn't supplied. This change is backwards compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you supply an object config (rather than a string), you're forced to override all of the defaults, which is overkill. Rather leave defaults intact if an override for that particular value wasn't supplied.
This change is backwards compatible.