Conversation
|
I've a hard time figuring out the allocation behaviour before and after, so now we preallocate? how big are the buffers being allocated? are those for each connection read and write direction? |
Contributor
Author
|
We can split the improvement into 3 parts:
From my experiment, it's a win but I'm currently try to provide a reproducible benchmark between |
Contributor
Author
|
I just need to keep in my mind that the second point (use the same buffer with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We just pre-allocated buffers to read/write and we improve a bit the code. We are also be able to catch-up earlier when the user wants to stop the server.