Skip to content

Fix: webhook readed only from the config file, not env #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arikalon1 merged 1 commit into from
Jan 7, 2026
Merged

Fix: webhook readed only from the config file, not env #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,6 +308,9 @@ func (c *Config) CheckMissingResourceEnvvars() {
if (c.Handler.SlackWebhook.Slackwebhookurl == "") && (os.Getenv("KW_SLACK_WEBHOOK_URL") != "") {
c.Handler.SlackWebhook.Slackwebhookurl = os.Getenv("KW_SLACK_WEBHOOK_URL")
}
if (c.Handler.Webhook.Url == "") && (os.Getenv("KW_WEBHOOK_URL") != "") {
c.Handler.Webhook.Url = os.Getenv("KW_WEBHOOK_URL")
}
}

func (c *Config) Write() error {
Expand Down
43 changes: 14 additions & 29 deletions config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ package config

import (
//"io/ioutil"
//"os"
//"testing"
"os"
"testing"
)

var configStr = `
Expand Down Expand Up @@ -48,30 +48,15 @@ var configStr = `
}
`

//func TestLoadOK(t *testing.T) {
// content := []byte(configStr)
// tmpConfigFile, err := ioutil.TempFile(homeDir(), "kubewatch")
// if err != nil {
// t.Fatalf("TestLoad(): %+v", err)
// }
//
// defer func() {
// _ = os.Remove(tmpConfigFile.Name())
// }()
//
// if _, err := tmpConfigFile.Write(content); err != nil {
// t.Fatalf("TestLoad(): %+v", err)
// }
// if err := tmpConfigFile.Close(); err != nil {
// t.Fatalf("TestLoad(): %+v", err)
// }
//
// ConfigFileName = "kubewatch"
//
// c, err := New()
//
// err = c.Load()
// if err != nil {
// t.Fatalf("TestLoad(): %+v", err)
// }
//}
func TestCheckMissingResourceEnvvars_Webhook(t *testing.T) {
expectedURL := "http://example.com/webhook"
os.Setenv("KW_WEBHOOK_URL", expectedURL)
defer os.Unsetenv("KW_WEBHOOK_URL")

c := &Config{}
c.CheckMissingResourceEnvvars()

if c.Handler.Webhook.Url != expectedURL {
t.Errorf("Expected Webhook URL to be %q, but got %q", expectedURL, c.Handler.Webhook.Url)
}
}