Improve sed IPv4 regex for loading plain lists#12
Open
ProBackup-nl wants to merge 1 commit intorobzr:masterfrom
Open
Improve sed IPv4 regex for loading plain lists#12ProBackup-nl wants to merge 1 commit intorobzr:masterfrom
ProBackup-nl wants to merge 1 commit intorobzr:masterfrom
Conversation
0.0.0.0/8 is reserved according to IANA since 1981. 0.x.x.x IPv4 addresses shouldn't be routable and not end up in an RBL. Though https://sigs.interserver.net/iprbl.txt contains 0.0.0.0 resulting in "ipset v6.29: Error in line 1: Null-valued element, cannot be stored in a hash type of set". This fix excludes 0.x.x.x addresses to end up in ipset lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.0.0.0/8 is reserved according to IANA since 1981. 0.x.x.x IPv4 addresses shouldn't be routable and not end up in an RBL.
Though https://sigs.interserver.net/iprbl.txt contains 0.0.0.0 resulting in "ipset v6.29: Error in line 1: Null-valued element, cannot be stored in a hash type of set".
This fix excludes 0.x.x.x addresses to end up in ipset lists.