Conversation
I thought that this would work now that we have an ICU build. But it doesn't. I'm going to have to do some more work on this.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
now that we can check against `null`, missing params is not an error. A missing param defaults to a `null` value. To be used in permission code where the `authData` may not exist.
These variables are collections of rules which are policies.
I tried `lit` on for size but it just felt more awkward.
Example:
```ts
issue.where(({cmp, lit}) => cmp(lit(22), '<', 42));
// vs
issue.where(({cmpLit}) => cmpLit(22, '<', 42));
// 1. cmpLit is less to type
// 2. cmpLit doesn't have the confusing asymmetry of only one literal needing to be wrapped in `lit`
```
Contributor
You got the ICU extensions building? |
Contributor
Author
I thought you got that working :-) |
Contributor
|
I got stuck on the windows build. |
Contributor
Author
|
This is still broken 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought that this would work now that we have an ICU build. But it doesn't. I'm going to have to do some more work on this.