Skip to content

solid | drain before adding to pending?#3695

Closed
tantaman wants to merge 1 commit intomainfrom
mlaw/solid
Closed

solid | drain before adding to pending?#3695
tantaman wants to merge 1 commit intomainfrom
mlaw/solid

Conversation

@tantaman
Copy link
Contributor

@tantaman tantaman commented Feb 3, 2025

Wdyt? Same as @arv's prior approach but drains the node before putting it on pending.

CleanShot 2025-02-03 at 16 28 40

@tantaman tantaman requested review from arv and grgbkr February 3, 2025 21:29
@vercel
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
replicache-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:29pm
zbugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 9:29pm

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

🐰 Bencher Report

Branchmlaw/solid
Testbedlocalhost
Click to view all benchmark results
BenchmarkFile SizeBenchmark Result
kilobytes (KB)
(Result Δ%)
Upper Boundary
kilobytes (KB)
(Limit %)
zero-package.tgz📈 view plot
🚷 view threshold
926.86
(+0.07%)
944.78
(98.10%)
zero.js📈 view plot
🚷 view threshold
174.66
(0.00%)
178.15
(98.04%)
zero.js.br📈 view plot
🚷 view threshold
48.66
(0.00%)
49.63
(98.04%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link

github-actions bot commented Feb 3, 2025

🐰 Bencher Report

Branchmlaw/solid
Testbedlocalhost
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers)📈 view plot
🚷 view threshold
77.13
(+5.86%)
68.20
(88.42%)
src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers)📈 view plot
🚷 view threshold
97.32
(+2.63%)
90.27
(92.75%)
🐰 View full continuous benchmarking report in Bencher

@tantaman
Copy link
Contributor Author

tantaman commented Feb 4, 2025

rolled into this change: #3701

@tantaman tantaman closed this Feb 4, 2025
@tantaman tantaman deleted the mlaw/solid branch March 24, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant