Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arv
commented
Feb 3, 2026
Contributor
Author
There was a problem hiding this comment.
This is the only interesting file
you can of course look at the imported stuff.
Contributor
Author
|
@aboodman This now works with no known bugs :-) I still have work to do to make the API better and figure out if I should upstream the fix or not. |
arv
force-pushed
the
arv/tanstack-virtual-fork-in-mono
branch
from
0337271 to
4ad276e
Compare
…ing scroll positions
This reverts commit 68759e9.
…djust estimateSize logic
…ased on viewport height
…ptions for clarity
…date ListPage to utilize new scroll state management
arv
force-pushed
the
arv/tanstack-virtual-fork-in-mono
branch
from
a216e2d to
9b544e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is using the fixed Tanstack Virtual from mono/packages/react-virtual/src/virtualizer.ts
the permalink does not work in this iteration
it is very hacky... it uses a Proxy which is not needed.