Make timeout a positional argument of triggered

[chhtz]

This allows calling it via send in @explicit_activity without deprecation warnings in ruby 2.7, and failures in ruby 3.2

@pierrewillenbrockdfki FYI

[pierrewillenbrockdfki]

Alternative implementations could teach default_activity about keyword arguments or pass a block. But in my opinion, only allowing positional arguments is fine.

[doudou]

Alternative implementations could teach default_activity about keyword arguments or pass a block. But in my opinion, only allowing positional arguments is fine.

Not in mine. We're using that parameter, we'd have to change everywhere it is actually used.

[doudou]

The right thing is to fix the forwarding of default_activity.

[chhtz]

The right thing is to fix the forwarding of default_activity.

I'm fine with that as well. My ruby skills are a bit limited for a proper fix then, however.
Feel free to overwrite this branch or make a new PR @doudou

[pierrewillenbrockdfki]

Happy new year everyone!

@doudou I found

tools-orogen/lib/orogen/loaders/project.rb

Lines 125 to 128 in 0950ec6

	if kw.empty?
	@spec.send(m, *args, &block)
	else
	@spec.send(m, *args, **kw, &block)

Is there a specific reason to not just always splat **kw? It seems to work fine in ruby 2.3.

[pierrewillenbrockdfki]

Currently testing pierrewillenbrockdfki@72a843c -- i believe this is already being used in our CI for Ubuntu 22.04 @chhtz does that work for your Ubuntu 24.04?