Skip to content

parseConfigMapFromYamlNode: add proper checking of input filename #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marvin2k wants to merge 1 commit into
base: master
Choose a base branch
from
Open

parseConfigMapFromYamlNode: add proper checking of input filename #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/ConfigData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,14 @@ namespace configmaps {

ConfigMap ConfigMap::fromYamlFile(const string &filename, bool loadURI) {
std::ifstream fin(filename.c_str());
if (!fin.good()) {
fprintf(stderr, "ERROR: ConfigMap::fromYamlFile failed! "
"Could not open input file \"%s\"\n",
filename.c_str());
// wouldn't it be better to throw? the returned map is empty, which
// might not be what the caller actually wants?
return ConfigMap();
}
ConfigMap map = fromYamlStream(fin);
if(loadURI) {
std::string pathToFile = getPathOfFile(filename);
Expand Down