Skip to content

Validate display mode input in CompanyInfo and User controllers, throw BadRequestException for invalid values #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Feb 25, 2025
Merged

Validate display mode input in CompanyInfo and User controllers, throw BadRequestException for invalid values #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions backend/src/entities/company-info/company-info.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {
BadRequestException,
Body,
Controller,
Delete,
Expand Down Expand Up @@ -336,6 +337,9 @@ export class CompanyInfoController {
@UserId() userId: string,
@Query('displayMode') displayMode: string,
): Promise<SuccessResponse> {
if (displayMode !== 'on' && displayMode !== 'off') {
throw new BadRequestException(Messages.INVALID_DISPLAY_MODE);
}
const newDisplayMode = displayMode === 'on';
const inputData: ToggleTestConnectionDisplayModeDs = {
userId,
Expand Down
4 changes: 4 additions & 0 deletions backend/src/entities/user/user.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {
BadRequestException,
Body,
Controller,
Get,
Expand Down Expand Up @@ -480,6 +481,9 @@ export class UserController {
@UserId() userId: string,
@Query('displayMode') displayMode: string,
): Promise<SuccessResponse> {
if (displayMode !== 'on' && displayMode !== 'off') {
throw new BadRequestException(Messages.INVALID_DISPLAY_MODE);
}
const newDisplayMode = displayMode === 'on';
const toggleConnectionDisplayModeDs = {
userId: userId,
Expand Down
1 change: 1 addition & 0 deletions backend/src/exceptions/text/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ export const Messages = {
INCORRECT_TABLE_LOG_ACTION_TYPE: `Incorrect log operation type, supported types are ${enumToString(
LogOperationTypeEnum,
)}`,
INVALID_DISPLAY_MODE: `Invalid display mode. Supported values are "on" and "off"`,
INVALID_USERNAME_OR_PASSWORD: `Username or password is invalid`,
INVALID_USER_COMPANY_ROLE: `Invalid user role in company. Only supported is ${enumToString(UserRoleEnum)}`,
INVALID_JWT_TOKEN: `JWT token syntax is invalid`,
Expand Down
Loading