Skip to content

Add validation for default showing table to prevent selection and exclusion in connection properties setup #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Feb 26, 2025
Merged

Add validation for default showing table to prevent selection and exclusion in connection properties setup #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions backend/src/entities/connection-properties/utils/validate-create-connection-properties-ds.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ export async function validateCreateConnectionPropertiesDs(
errors.push(Messages.TABLE_WITH_NAME_NOT_EXISTS(hiddenTable));
}
}
if (hidden_tables.includes(default_showing_table)) {
errors.push(Messages.CANT_SHOW_TABLE_AND_EXCLUDE(default_showing_table));
}
}

if (default_showing_table && !tablesInConnection.includes(default_showing_table)) {
Expand Down
2 changes: 2 additions & 0 deletions backend/src/exceptions/text/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ export const Messages = {
'It seems like the value you entered for the unique field already exists in database. Please check your input and try again with a different value',
CANT_LIST_AND_EXCLUDE: (fieldName: string) =>
`You cannot select the same field ${fieldName ? fieldName : 'names'} to list and exclude`,
CANT_SHOW_TABLE_AND_EXCLUDE: (tableName: string) =>
`You cannot select the same table "${tableName}" to show by default and exclude`,
CANT_VIEW_AND_EXCLUDE: (fieldName: string) =>
`You cannot select the same field ${fieldName ? fieldName : 'names'} to view and exclude`,
CANT_ORDER_AND_EXCLUDE: `You cannot select the same field names to order and exclude`,
Expand Down
Loading