Conversation
…ate related tests
Contributor
There was a problem hiding this comment.
Pull request overview
Adds cedarPolicy to group-shaped response payloads so clients can access the stored Cedar authorization policy alongside existing group metadata, and updates end-to-end tests to assert the field is present.
Changes:
- Extend group response data structures/DTOs to include
cedarPolicy: string | null. - Populate
cedarPolicyin group mappers/builders (groups list, groups-in-connection, company full info, update-group-title response). - Update SaaS and non-SaaS E2E tests to assert
cedarPolicyexists and adjust key-count assertions.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| backend/test/ava-tests/saas-tests/group-e2e.test.ts | Assert cedarPolicy is present in groups listing responses. |
| backend/test/ava-tests/saas-tests/connection-e2e.test.ts | Assert cedarPolicy is present in groups-in-connection responses after deletion. |
| backend/test/ava-tests/saas-tests/company-info-e2e.test.ts | Update group object key count and assert cedarPolicy exists in company full info response. |
| backend/test/ava-tests/non-saas-tests/non-saas-group-e2e.test.ts | Mirror SaaS group E2E assertions for cedarPolicy. |
| backend/test/ava-tests/non-saas-tests/non-saas-connection-e2e.test.ts | Mirror SaaS connection E2E assertions for cedarPolicy. |
| backend/test/ava-tests/non-saas-tests/non-saas-company-info-e2e.test.ts | Mirror SaaS company-info E2E assertions for cedarPolicy and key counts. |
| backend/src/entities/group/use-cases/update-group-title.use.case.ts | Include cedarPolicy in update-group-title response shape. |
| backend/src/entities/group/use-cases/find-all-user-groups.use.case.ts | Include cedarPolicy when mapping user groups. |
| backend/src/entities/group/application/data-sctructures/found-user-groups.ds.ts | Add `cedarPolicy: string |
| backend/src/entities/connection/utils/build-found-user-group-in-connection-dto.util.ts | Populate cedarPolicy in the groups-in-connection response builder. |
| backend/src/entities/connection/application/dto/found-user-groups-in-connection.dto.ts | Add `cedarPolicy: string |
| backend/src/entities/company-info/utils/build-found-company-info-ds.ts | Include cedarPolicy in groups returned by company full info builder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @ApiProperty() | ||
| isMain: boolean; | ||
|
|
||
| @ApiProperty() |
| @ApiProperty() | ||
| isMain: boolean; | ||
|
|
||
| @ApiProperty() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.