Skip to content

refactor: simplify policy reference validation and enable feature flag #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Artuomka merged 1 commit into from
Mar 18, 2026
Merged

refactor: simplify policy reference validation and enable feature flag #1676

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 16 additions & 21 deletions backend/src/entities/cedar-authorization/cedar-authorization.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ export class CedarAuthorizationService implements ICedarAuthorizationService, On
}

isFeatureEnabled(): boolean {
return process.env.CEDAR_AUTHORIZATION_ENABLED === 'true';
// return process.env.CEDAR_AUTHORIZATION_ENABLED === 'true';
return true;
Comment on lines +40 to +41
}

async validate(request: CedarValidationRequest): Promise<boolean> {
Expand Down Expand Up @@ -265,13 +266,10 @@ export class CedarAuthorizationService implements ICedarAuthorizationService, On
}
}

private async validatePolicyReferences(
cedarPolicy: string,
connectionId: string,
): Promise<void> {
const connectionIds = [
...cedarPolicy.matchAll(/resource\s*==\s*RocketAdmin::Connection::"([^"]+)"/g),
].map((m) => m[1]);
private async validatePolicyReferences(cedarPolicy: string, connectionId: string): Promise<void> {
const connectionIds = [...cedarPolicy.matchAll(/resource\s*==\s*RocketAdmin::Connection::"([^"]+)"/g)].map(
(m) => m[1],
);

for (const refConnectionId of connectionIds) {
if (refConnectionId !== connectionId) {
Expand All @@ -282,27 +280,24 @@ export class CedarAuthorizationService implements ICedarAuthorizationService, On
}
}

const groupResourceIds = [
...cedarPolicy.matchAll(/resource\s*==\s*RocketAdmin::Group::"([^"]+)"/g),
].map((m) => m[1]);
const groupResourceIds = [...cedarPolicy.matchAll(/resource\s*==\s*RocketAdmin::Group::"([^"]+)"/g)].map(
(m) => m[1],
);

if (groupResourceIds.length > 0) {
const connectionGroups = await this.globalDbContext.groupRepository.findAllGroupsInConnection(connectionId);
const connectionGroupIds = new Set(connectionGroups.map((g) => g.id));

for (const refGroupId of groupResourceIds) {
if (!connectionGroupIds.has(refGroupId)) {
throw new HttpException(
{ message: Messages.CEDAR_POLICY_REFERENCES_FOREIGN_GROUP },
HttpStatus.BAD_REQUEST,
);
throw new HttpException({ message: Messages.CEDAR_POLICY_REFERENCES_FOREIGN_GROUP }, HttpStatus.BAD_REQUEST);
}
}
}

const tableResourceIds = [
...cedarPolicy.matchAll(/resource\s*==\s*RocketAdmin::Table::"([^"]+)"/g),
].map((m) => m[1]);
const tableResourceIds = [...cedarPolicy.matchAll(/resource\s*==\s*RocketAdmin::Table::"([^"]+)"/g)].map(
(m) => m[1],
);

for (const tableRef of tableResourceIds) {
if (!tableRef.startsWith(`${connectionId}/`)) {
Expand All @@ -313,9 +308,9 @@ export class CedarAuthorizationService implements ICedarAuthorizationService, On
}
}

const dashboardResourceIds = [
...cedarPolicy.matchAll(/resource\s*==\s*RocketAdmin::Dashboard::"([^"]+)"/g),
].map((m) => m[1]);
const dashboardResourceIds = [...cedarPolicy.matchAll(/resource\s*==\s*RocketAdmin::Dashboard::"([^"]+)"/g)].map(
(m) => m[1],
);

for (const dashboardRef of dashboardResourceIds) {
if (!dashboardRef.startsWith(`${connectionId}/`)) {
Expand Down
Loading