FTBC13-Project1: Biquidity Trading Game#35
Open
spenceryang wants to merge 12 commits intorocketacademy:mainfrom
Open
FTBC13-Project1: Biquidity Trading Game#35spenceryang wants to merge 12 commits intorocketacademy:mainfrom
spenceryang wants to merge 12 commits intorocketacademy:mainfrom
Conversation
… Navigation across states and pages works
…push for now and focus on UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Site is on: https://game.biquidity.com
Please fill out the survey before submitting the pull request. Thanks! 🚀:
How many hours did you spend on this assignment?:
<1 week starting from ideation, planning to execution.
Please fill in one error and/or error message you received while working on this assignment.:
Too many.
What part of the assignment did you spend the most time on?:
Debugging when I went down a rabbit hole of extending the core logic for portfolio, prices over a period of time and news over some time. Handling historical data in the session and passing props from parent to child etc.
Comfort Level (1-5):
3
Completeness Level (1-5):
3.5
What did you think of this deliverable?
Great practice to scope, implement a project end to end within the given timelines. Definitely felt a bit pressured and rushed to bring things to a certain polish. Wished I have more time to dedicate to the project for the past week.
Is there anything in this code that you feel pleased about?
Realized most of the core flows that I set out to.
What's one aspect of your code you would like specific, elaborate feedback on?
What do you think I could have pushed more on for this project?