Open
Conversation
Flashrob
reviewed
Dec 8, 2023
| @@ -13,3 +13,23 @@ Open [http://localhost:3000](http://localhost:3000) to view it in your browser. | |||
|
|
|||
There was a problem hiding this comment.
Would be great to also include install instructions!
| "@emotion/styled": "^11.11.0", | ||
| "@mui/icons-material": "^5.14.16", | ||
| "@mui/material": "^5.14.17", | ||
| "gh-pages": "^6.1.0", |
There was a problem hiding this comment.
I think this is probably a dev dependency. Can try using npm install -D gh-pages to install as dev dependency
| justifyContent: "center", | ||
| alignItems: "center", | ||
| padding: "5px 20px", | ||
| // bgcolor: "#daa06d", |
| import HomeIcon from "@mui/icons-material/Home"; | ||
| import { useNavigate } from "react-router-dom"; | ||
|
|
||
| const modalStyles = { |
There was a problem hiding this comment.
nice job defining this outside of the component
| setIsTransactionFormShown, | ||
| }) => { | ||
| const [showMessage, setShowMessage] = useState([]); | ||
| const [open, setOpen] = useState(false); |
There was a problem hiding this comment.
I would rather name this isOpen like a boolean
| }; | ||
|
|
||
| const handleSubmit = () => { | ||
| if (!activity || !items) { |
There was a problem hiding this comment.
I like your early returns, very good practice!
Comment on lines
+7
to
+9
| if (getActivityData) { | ||
| return true; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (getActivityData) { | |
| return true; | |
| } | |
| if (getActivityData) return true; |
curly braces are not necessary for one liners, feel free to use it if you like it
Comment on lines
+14
to
+18
| const getActivityData = JSON.parse(localStorage.getItem("activityDetails")); | ||
|
|
||
| const [activityDetails, setActivityDetails] = useState( | ||
| getActivityData ? getActivityData : { activity: "", items: "" } | ||
| ); |
There was a problem hiding this comment.
Suggested change
| const getActivityData = JSON.parse(localStorage.getItem("activityDetails")); | |
| const [activityDetails, setActivityDetails] = useState( | |
| getActivityData ? getActivityData : { activity: "", items: "" } | |
| ); | |
| const [activityDetails, setActivityDetails] = useState( | |
| JSON.parse(localStorage.getItem("activityDetails")) || { activity: "", items: "" } | |
| ); |
Comment on lines
+23
to
+43
| return ( | ||
| <> | ||
| {!isTransactionFormShown ? ( | ||
| <> | ||
| <CreateForm | ||
| setActivityDetails={setActivityDetails} | ||
| setIsTransactionFormShown={setIsTransactionFormShown} | ||
| /> | ||
| </> | ||
| ) : ( | ||
| <> | ||
| <div style={{ overflow: "auto", height: "50vh" }}> | ||
| <AddTransactionsForm | ||
| activityDetails={activityDetails} | ||
| setIsTransactionFormShown={setIsTransactionFormShown} | ||
| /> | ||
| </div> | ||
| </> | ||
| )} | ||
| </> | ||
| ); |
There was a problem hiding this comment.
Suggested change
| return ( | |
| <> | |
| {!isTransactionFormShown ? ( | |
| <> | |
| <CreateForm | |
| setActivityDetails={setActivityDetails} | |
| setIsTransactionFormShown={setIsTransactionFormShown} | |
| /> | |
| </> | |
| ) : ( | |
| <> | |
| <div style={{ overflow: "auto", height: "50vh" }}> | |
| <AddTransactionsForm | |
| activityDetails={activityDetails} | |
| setIsTransactionFormShown={setIsTransactionFormShown} | |
| /> | |
| </div> | |
| </> | |
| )} | |
| </> | |
| ); | |
| if (!isTransactionFormShown) return <CreateForm ... /> | |
| return ( | |
| <div style={{ overflow: "auto", height: "50vh" }}> | |
| <AddTransactionsForm | |
| activityDetails={activityDetails} | |
| setIsTransactionFormShown={setIsTransactionFormShown} | |
| /> | |
| </div> | |
| ); |
There was a problem hiding this comment.
We can also return early for components to improve readability
| return greetings; | ||
| }; | ||
|
|
||
| let greetMessage = `${greetUser()} ${username},`; |
There was a problem hiding this comment.
Suggested change
| let greetMessage = `${greetUser()} ${username},`; | |
| const greetMessage = `${greetUser()} ${username},`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.