Change expiration date properly#213
Draft
mattiasdrp wants to merge 1 commit intorocq-prover:masterfrom
Draft
Conversation
I mistakenly wrote 55*10 instead of 60*8 since it's not 55 minutes instead of 60 but 8 minutes instead of 10 A safe way would be, if you want me to try it, to > date && curl -I https://api.github.com | grep -Fi "date" Read the two dates, compute the difference in time and create the expected expiration date for the token accordingly. This way, it doesn't matter if your computer is way out of sync, you'll always be able to provide GitHub with the proper dates.
Zimmi48
approved these changes
Apr 2, 2022
Member
Zimmi48
left a comment
Zimmi48
left a comment
There was a problem hiding this comment.
I think this change is fine. Why is this marked as draft?
Contributor
Author
Because of the second part:
|
Member
|
The proposal in the second part looks fine to me as well (though would it be possible to do it entirely on the OCaml side instead of calling external commands?). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I mistakenly wrote
55*10instead of60*8since it's not 55 minutes instead of 60 but 8 minutes instead of 10A safe way would be, if you want me to try it, to
Read the two dates, compute the difference in time and create the expected expiration date for the token accordingly. This way, it doesn't matter if your computer is way out of sync, you'll always be able to provide GitHub with the proper dates.