Fix TypeError in IRVisitor when expressions are undefined due to parse errors#1
Draft
Fix TypeError in IRVisitor when expressions are undefined due to parse errors#1
Conversation
Add defensive guards in walkDefinition and walkDeclaration to handle undefined expressions that can occur during parse errors. This prevents the "Cannot read properties of undefined (reading 'kind')" error. - Add null checks before calling walkExpression for def.expr - Add null checks before calling walkExpression for def.assumption - Add null checks before calling walkExpression for instance overrides - Add comprehensive test cases for all three scenarios Co-authored-by: roehst <21047691+roehst@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix TypeError when reading properties of undefined in IRVisitor
Fix TypeError in IRVisitor when expressions are undefined due to parse errors
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(including screenshots is helpful)
CHANGELOG.mdfor any new functionalityDescription
The IRVisitor crashed with
TypeError: Cannot read properties of undefined (reading 'kind')when encountering malformed IR from parse errors. The visitor unconditionally calledwalkExpression()on fields that can be undefined.Changes
quint/src/ir/IRVisitor.ts
walkExpression()calls in three locations:OpDef.expr(line 381)Assume.assumption(line 402)Instance.overridesexpressions (line 303)quint/test/ir/IRVisitor.test.ts
Example
Before this change, malformed IR like:
Now handles gracefully by skipping the undefined expression walk.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.