Refactor plugin lifecycle cleanup in PluginContext#1259
Open
Ayrton09 wants to merge 1 commit intoroflmuffin:mainfrom
Open
Refactor plugin lifecycle cleanup in PluginContext#1259Ayrton09 wants to merge 1 commit intoroflmuffin:mainfrom
Ayrton09 wants to merge 1 commit intoroflmuffin:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves plugin lifecycle cleanup in
PluginContextby making disposal explicit, idempotent, and centralized.Why
PluginContextcurrently owns several long-lived resources during a plugin's lifetime:ServiceProviderFileSystemWatcherwhen hot reload is enabledAt the moment, unload/cleanup behavior is not fully centralized, which makes repeated unload/reload cycles harder to reason about and increases the risk of leaked resources.
This PR keeps the scope intentionally small and only focuses on
PluginContextresource ownership and cleanup.Changes
IDisposableonPluginContextLoader.Reloadedbefore disposing the loaderServiceProviderNotImplementedExceptionused in self-termination withPluginTerminationExceptionNon-goals
This PR does not:
PluginManagerownership rulescss_plugins unload/reloadThose changes are better handled in follow-up PRs.
Testing
Files to review
managed/CounterStrikeSharp.API/Core/Plugin/PluginContext.cs