Skip to content

Docker tool path update#20

Merged
rjcorb merged 1 commit intomainfrom
rjcorb/docker-mv-tools
Sep 23, 2025
Merged

Docker tool path update#20
rjcorb merged 1 commit intomainfrom
rjcorb/docker-mv-tools

Conversation

@rjcorb
Copy link
Contributor

@rjcorb rjcorb commented Sep 5, 2025

Purpose/implementation Section

What scientific question is your analysis addressing?

Copies DiaTracer, MSFragger, and IonQuant jar files to same tool dir as other fragpipe dependencies

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

  1. Pull latest docker image following instructions in README and bash within container. Then confirm the following tools are in directory /fragpipe_bin/fragPipe-23.1/fragpipe-23.1/tools/:
diaTracer-1.3.3.jar
IonQuant-1.11.11.jar
MSFragger-4.3.jar

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • The analytical code is documented and contains comments.

@rjcorb rjcorb merged commit fb4702a into main Sep 23, 2025
1 check passed
@rjcorb rjcorb deleted the rjcorb/docker-mv-tools branch September 23, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants