Workflow for running fragpipe on impact trial test data #23
Closed
Workflow for running fragpipe on impact trial test data #23
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose/implementation Section
What scientific question is your analysis addressing?
This PR adds required scripts, reference files, manifest, and workflow files to run fragpipe on IMPACT trial test data.
NOTE that there are still a few steps that need to be taken before this can be run:
Download mzML files. These need to be downloaded from
s3://bti-private-us-east-1-prd-impact-trial/source/. I think something like the following command should work from root:After download, you should see 8 run-specific folders in the destination directory, each containing 8 mzML files corresponding to the 8 fractions.
impact-trialrepo: https://github.com/childrens-bti/impact-trial/blob/main/analyses/translation/results/custom_filtered.fasta. This file needs to be copied toimpact-trial/input/What was your approach?
What GitHub issue does your pull request address?
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Which areas should receive a particularly close look?
After downloading data into correct directory paths and pulling latest docker image, run fragpipe on impact trial data by executing the following from root:
Is there anything that you want to discuss further?
I am not sure how large of an ec2 instance this needs, but for reference I have run an a m6i.4xlarge. Our larger runs (with >100 CPTAC or HOPE samples) have required an instance of this size, but for a smaller data set it may not be required.
Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Results
What types of results are included (e.g., table, figure)?
What is your summary of the results?
Reproducibility Checklist
Documentation Checklist
READMEand it is up to date.