Adds Turbo Macro Pro X support as discussed in issue #96#99
Open
Llamato wants to merge 16 commits intorolandshacks:masterfrom
Open
Adds Turbo Macro Pro X support as discussed in issue #96#99Llamato wants to merge 16 commits intorolandshacks:masterfrom
Llamato wants to merge 16 commits intorolandshacks:masterfrom
Conversation
These are constants for representing PETSCII codes that can't be typed on PC
To avoid seeing all label uses as macro calls in instructions, such as `lda#const`, macros can only be invoked at the start of a line or after a label (maybe other cases?). The loose detection of acme macros (`+...`) impacts operator usage; acme also should only be identifying macro calls before instructions.
It's hard to choose what scopes to use, out-of-the-box syntax colours for assembly are pretty poor for assembly in VSCode.
Owner
|
From a first quick view, I think you need to revise the handling of different assembler language/grammar files. A recent improvement was dynamic toggling between grammars/language specs based on the chosen toolchain (from the project config). It seems like you added the tmpx language support to the more generic "asm" grammar/language file. |
Owner
|
And a more general question: after you added tmpx support, did you test all other features and toolchains also, all examples, all debugging start/stop, setting breakpoints, etc. ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As can be seen from the included commit messages we have
Missing so far is
What do you think?