Open
Conversation
Closed
arnauddorgans
force-pushed
the
spm
branch
8 times, most recently
from
97a9304 to
d0ebd50
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👨🎤 Motivation
SPM
👁 How?
lib/build_xcframework.shit createsxcframeworkfromframeworkPackage.swiftfile📓 Notes
This PR makes ROX SPM compliant but you have also to update your CI scripts, I'm not sure you should use
frameworkinstead ofxcframework.-> What is the point of https://github.com/rollout/rox-ios repo ?
All of the SDK's sources are here, I added a dependency from rox-ios to rox-ios-core but I don't see the point, the same swift files are also available in this repo