This repository was archived by the owner on Feb 20, 2019. It is now read-only.
Open
Conversation
The `close` handler when `stdin` is `end`ed is not being called. Calling `resume()` on `process.stdin` will enable that handler so it will be called properly. It should 'probably' be called earlier in the program, perhaps at the very start, but if it spools up fast enough it should not matter, and this is the same place similar code in other projects places it as well.
|
@OvermindDL1 it's now merged in the rollup repo |
Author
|
Ah, wouldn't have thought it goes there, weird. ^.^; Does it work for the watcher from the main rollup repo @LostKobrakai ? |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
closehandler whenstdinisended is not being called. Callingresume()onprocess.stdinwill enable that handler so it will be called properly. It should 'probably' be called earlier in the program, perhaps at the very start, but if it spools up fast enough it should not matter, and this is the same place similar code in other projects places it as well.Properly fixes #30