Add python-sounddevice and set it the default audio library #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanz
requested changes
Jan 5, 2024
Owner
romanz
left a comment
romanz
left a comment
There was a problem hiding this comment.
Many thanks for the contribution!
Could you please fix the CI failures?
https://github.com/romanz/amodem/actions/runs/7413654726/job/20175146678?pr=69#step:5:16
Author
|
Should be good now. |
romanz
requested changes
Jan 7, 2024
romanz
requested changes
Jan 8, 2024
Owner
romanz
left a comment
romanz
left a comment
There was a problem hiding this comment.
Please also squash the commits.
amodem/__main__.py
Outdated
| args.pylab = pylab | ||
|
|
||
| if args.audio_library == 'ALSA': | ||
| if args.audio_library == 'alsa': |
Owner
There was a problem hiding this comment.
Can we keep the old value (for compatibility)?
Author
There was a problem hiding this comment.
We can but the ALSA option wasn't even documented before...
ptsmonteiro
force-pushed
the
sounddevice
branch
from
1baa87c to
feb9924
Compare
ptsmonteiro
force-pushed
the
sounddevice
branch
from
feb9924 to
5342fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the python-sounddevice audio library (and makes it the default) which makes amodem work out-of-the-box on Linux, Windows and MacOS.