Add scenes out cluster (+ add some mandatory attributes while at it)#174
Add scenes out cluster (+ add some mandatory attributes while at it)#174ThatMishakov wants to merge 4 commits intoromasku:mainfrom
Conversation
|
Thank you for implementing scenes! This is very cool and meaningful for the project 😃👍🏻 Right now the PR is a little overwhelming for me.. I can't review it because I have never used scenes. Anyway I suggest we fix the TODO step-by-step before we merge scenes into main.
I can do the tasks (I wanted to do them anyway), but it will take some time. Right now I want to fix the generic converters and test them with older Z2M versions.. see how far we can go until they break. Then split them into 2 versions. |
The double click should already get disabled if you set the scene_count to 0. It can be checked by locking at Also, the main problem I see with configurable de-bounce (and reset) is that that would be even more attributes, if it's not an issue I guess I can also do it myself |
41793f2 to
cf07e56
Compare
This pull request adds a double click, scene out cluster, 4 new attributes for it (in OnOff switch config cluster), and also adds mandatory Cluster revision to all clusters in switch_cluster.c
This allows to cycle through scenes with a double click of the switch, which has many (awesome) applications with bindings, which include the following:
The following new attributes are added:
For example, if scene count is set to 3, and scene offset is set to 10, double clicks will recall scenes 10 -> 11 -> 12 -> 10 and so on.
Some considerations/TODO stuff:
short_pressactions, which is kinda against the spirit of the project, but I think it's an acceptable compromise for the (optional) extra functionalitybutton.cis a bit of a mess, and by the time @andrei-lazarov told me about ✨ NC momentary buttons + action states for toggle buttons #160 (comment) it was too late. But it works