🔒 Fix loose type comparison vulnerability in Cif.php#211
Conversation
Replaced == with === when comparing control digits in Cif::validate to prevent unintended type coercions. Casted computed control digit to string where necessary to match the string type of the character extracted from the CIF string. Co-authored-by: ronanguilloux <313677+ronanguilloux@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: Fixed a vulnerability in
src/IsoCodes/Cif.phpcaused by loose type comparison (==) when validating the control digit of a CIF.==instead of===allows unexpected type coercions (type juggling vulnerabilities). For instance, in PHP, string comparisons like"0e123" == "0e456"evaluate to true. If a malformed CIF string evaluated numerically equals the calculated control digit, the validator would incorrectly accept it as valid, potentially bypassing system validations.🛡️ Solution:
==operators with strict comparison===operators.$controlDigitto a string ((string) $controlDigit) before comparing it strictly against$cif[8](which is a string character).$cif[8]and$cifCodes[$controlDigit]strictly, as both evaluate to string characters.Tested locally, ran code formatters, and successfully passed the test suite (
make tests&make quality).PR created automatically by Jules for task 17394091391970110120 started by @ronanguilloux