Update InsertionSort.java#64
Open
Vsareen0 wants to merge 2 commits intoronijpandey:masterfrom
Vsareen0:patch-1
Open
Update InsertionSort.java#64Vsareen0 wants to merge 2 commits intoronijpandey:masterfrom Vsareen0:patch-1
Vsareen0 wants to merge 2 commits intoronijpandey:masterfrom
Vsareen0:patch-1
Conversation
|
In the insertion sort when you put "arr[j+1] = key;", I believe it is unnecessary since you have arr[j+1] = arr[j] where arr[i] will always be key. Regards, Shayan Asgari |
|
Inside the while loop there is also a problem. You do not do any swapping of integers, you are simply overriding the original array! You must have: |
Vsareen0
commented
Oct 16, 2018
Author
Vsareen0
left a comment
There was a problem hiding this comment.
Please have a look at modifications !
|
I believe the code is still incorrect. You are overriding some of the position values. Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments have been added for the implementation of insertion sort algorithm