fix "from_buffer_copy" byte values format#1
Open
latchdevel wants to merge 1 commit intoronyb29:masterfrom
Open
fix "from_buffer_copy" byte values format#1latchdevel wants to merge 1 commit intoronyb29:masterfrom
latchdevel wants to merge 1 commit intoronyb29:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Rony.
Thank you very much for sharing your work.
I have tried to use this module, but usage example doesn't work correctly.
The problem seems to be in the "from_buffer_copy" method inherited from the "BigEndianStructure" class, which expects a bytes object as hex, not as str.
I make this pull request in case you consider it appropriate to modify it.
Anyway, I have made an alternate, simpler raw implementation.
https://github.com/latchdevel/AN575
I hope you find it useful.
Best regards.
Jorge Rivera.