[hist] Implement initial RHistEngine
#19732
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface allows convenient iteration over RBinIndex.
Needed in the public interface of the histogram classes, so it should not be in the Internal namespace.
It combines an RAxes object and storage of bin contents.
This results in proper error messages when trying to stream. Other instantiations will be caught by the RAxes member.
Test Results 21 files 21 suites 3d 15h 3m 27s ⏱️ For more details on these failures, see this check. Results for commit 18fb91d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It combines an
RAxesobject and storage of bin contents.Builds on #19694, first two commits with the implementation of
RBinIndexRangeshould be reviewed there.